Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for mainline version #450

Closed
jg-development opened this issue Sep 18, 2014 · 2 comments · Fixed by #519
Closed

Add support for mainline version #450

jg-development opened this issue Sep 18, 2014 · 2 comments · Fixed by #519

Comments

@jg-development
Copy link
Contributor

Supporting the mainline version would be a nice feature for the repo part of the nginx module.
http://nginx.org/en/linux_packages.html#mainline

Greetings Jan

@3flex
Copy link
Contributor

3flex commented Dec 8, 2014

@jg-development I've been hacking away at the package classes over the weekend, and as part of that added support for installing the mainline packages from upstream.

Could you take a look at https://github.com/3flex/puppet-nginx/tree/refactor-packages and see if this would suit? It takes a slightly different approach (i.e. reusing the $package_source parameter instead of introducing a new one) but should meet your requirements.

I need to squash the last dozen or so commits and add some new tests for the functionality I've added, but I intend to raise a PR later today for review.

@jg-development
Copy link
Contributor Author

Hi,
the fork seems to work for me. But I will test it with my vagrant servers and hiera at weekend.
I will give you feedback as soon as I can. But it looks good for me.
Greetings Jan

cegeka-jenkins pushed a commit to cegeka/puppet-nginx that referenced this issue Oct 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants