This repository has been archived by the owner on May 31, 2021. It is now read-only.
Add TravisCI config and make tests pass #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfurrow
force-pushed
the
configure-ci
branch
from
ee7172b
to
8bf303f
Compare
dcousens
reviewed
Nov 29, 2017
| @@ -1,5 +1,8 @@ | |||
| 'use strict'; | |||
|
|
|||
| console.log('There are no tests yet.'); | |||
jfurrow
force-pushed
the
configure-ci
branch
from
89e0ee4
to
58c8d80
Compare
|
I guess OS X builds are extremely slow to start, so I'm not going to enable them for now. One user observed an average of 3 hours, which is just too slow. |
jfurrow
force-pushed
the
configure-ci
branch
from
58c8d80
to
8bf303f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are a bunch of lint warnings here, but let's address those along with #555
Related Issue
Closes #556
Motivation and Context
How Has This Been Tested?
By this PR!
Types of changes
Checklist: