Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestFX upgrade #76

Closed
Maxoudela opened this issue Nov 22, 2016 · 5 comments
Closed

TestFX upgrade #76

Maxoudela opened this issue Nov 22, 2016 · 5 comments
Assignees

Comments

@Maxoudela
Copy link
Member

Hi,

I'm wondering if we could try to upgrade the TestFX version to at least 4.0 ? Or is there any reasons we should not?

My keyboard is in French, and each time I run the JFXtras tests, the tests are failing because I need to put my keyboard in QWERTY otherwise the input are wrong. Also my mouse settings are put back to default.

These issues are currently fixed from 4.0 TestFX version. Also, the tests can be ran in HeadLess mode which is very nice because you can actually do something else when the tests are running (and you even can run them in a device that hasn't any screen).

Honestly, I don't know the amount of work to do the migration, but since I'm using TestFX 4.0 in my application, I think I can do it without too much difficulty..

@Maxoudela Maxoudela self-assigned this Nov 22, 2016
@tbee
Copy link
Member

tbee commented Nov 22, 2016

I've been holding this off unit 4.0 was out officially, because I have quite a number of tests and have a lot of tuning in the tests cases. But yes, it is on my todo list. But having to choose between working on ResponsivePane and upgrading TestFX. Well... ;-)

@Maxoudela
Copy link
Member Author

What is Responsivepane..?

Honestly, I've seen what are in the tests, but most of the things you implemented in your test cases are in TestFX. If not, maybe it would be great adding them into TestFX directly. If you need them, there's some chance others will need it too no?

@tbee
Copy link
Member

tbee commented Nov 23, 2016

Yes, yes, it should be doable. The author of TestFX warned me that it would be quite a bit of work. But let's give it a shot.

@tbee
Copy link
Member

tbee commented Nov 23, 2016

ResponsivePane is my attempt to do responsive layout, by having a layout that automatically chooses the best fitting one, and also by replacing CSS files based on screen width. It turned out that the implementation by GUI Garage did not work on mobile. I've written some blogs about that.

I'm still in the middle of it all, but the current state looks like this:
https://github.com/JFXtras/jfxtras-labs/blob/8.0/src/test/resources/jfxtras/labs/scene/layout/ResponsivePaneFXMLDemo.fxml

@tbee
Copy link
Member

tbee commented Jun 4, 2017

TestFX 4.x is being used

@tbee tbee closed this as completed Jun 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants