Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Named cycle groups #43

Closed
jg-rp opened this issue Feb 16, 2022 · 1 comment
Closed

Named cycle groups #43

jg-rp opened this issue Feb 16, 2022 · 1 comment
Labels
incompatibility Behavioural differences between Python and Ruby Liquid

Comments

@jg-rp
Copy link
Owner

jg-rp commented Feb 16, 2022

When the cycle tag is given a name, Python Liquid will use that name and all other arguments to distinguish one cycle from another. Ruby Liquid will disregard all other arguments when given a name. For example.

{% cycle a: 1, 2, 3 %}
{% cycle a: "x", "y", "z" %}
{% cycle a: 1, 2, 3 %}

Ruby Liquid Output:

1
y
3

Python Liquid Output:

1
x
2
@jg-rp jg-rp added bug Something isn't working incompatibility Behavioural differences between Python and Ruby Liquid and removed bug Something isn't working labels Feb 16, 2022
@jg-rp
Copy link
Owner Author

jg-rp commented Dec 31, 2022

Fixed with #99 and the use of liquid.future.Environment instead of liquid.Environment.

@jg-rp jg-rp closed this as completed Dec 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
incompatibility Behavioural differences between Python and Ruby Liquid
Projects
None yet
Development

No branches or pull requests

1 participant