Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Deprecate direct s4c-script vendoring #87

Open
jgabaut opened this issue Jan 19, 2024 · 1 comment
Open

[FEATURE] Deprecate direct s4c-script vendoring #87

jgabaut opened this issue Jan 19, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@jgabaut
Copy link
Owner

jgabaut commented Jan 19, 2024

As of version 0.4.3, the ./scripts directory contains some wrappers that should emulate previous behaviour.

This is sprites.py, for example:

#!/bin/python3

import sys
from s4c.core.sprites import main

if __name__ == "__main__":
    main(sys.argv)

The import works by leveraging a symlink for ./scripts/s4c:

./scripts/s4c -> ./s4c-scripts/s4c.

The old versions of the scripts are available under ./scripts-legacy.

Eventually, these will be removed. The patch needed in any Makefile using the scripts directly would be something like this:

< 	python3 ./sprites4curses/scripts/palette.py C-impl $(PALETTE_PATH) .. > ./src/palette.c
< 	python3 ./sprites4curses/scripts/palette.py C-header $(PALETTE_PATH) .. > ./src/palette.h
---
> 	python3 -m sprites4curses.s4c-scripts.s4c.core.palette C-impl $(PALETTE_PATH) .. > ./src/palette.c
> 	python3 -m sprites4curses.s4c-scripts.s4c.core.palette C-header $(PALETTE_PATH) .. > ./src/palette.h
@jgabaut jgabaut added the enhancement New feature or request label Jan 19, 2024
@jgabaut
Copy link
Owner Author

jgabaut commented Jan 26, 2024

Version 0.4.4 drops the old scripts (scripts-legacy/).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant