Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License terms are not explicit #42

Closed
cornwarecjp opened this issue Jan 10, 2015 · 4 comments
Closed

License terms are not explicit #42

cornwarecjp opened this issue Jan 10, 2015 · 4 comments

Comments

@cornwarecjp
Copy link

The docstring in authproxy.py mentions that there is a "Previous copyright, from python-jsonrpc/jsonrpc/proxy.py", which refers to the "GNU Lesser General Public License as published by the Free Software Foundation; either version 2.1 of the License, or (at your option) any later version."

So, I suppose I can reasonably assume that python-bitcoinrpc is at least compatible with LGPL v2.1 or later. However, this still leaves some room for unclarity; I don't think that, the way it is now, I can be 100% certain that all of python-bitcoinrpc is available under LGPL v2.1 or later.

If it is the intention of all contributors to release their contributions under LGPL v2.1 or later (I hope this is the case), then please make it explicit.

Also, as a minor note: since the docstring says "You should have received a copy of the GNU Lesser General Public License along with this software", I think you should actually include a copy of the LGPL in the source tree.

@koobs
Copy link

koobs commented Aug 6, 2015

Also, add LICENSE file to repository, and include it in PyPI sdist (using MANIFEST.in)

@ghost
Copy link

ghost commented Aug 6, 2015

+1

@maflcko
Copy link

maflcko commented Nov 23, 2015

Looks like this was fixed by 8fcbaf0

@koobs
Copy link

koobs commented Nov 23, 2015

@MarcoFalke Confirmed, LICENSE is in the latest PyPI 0.3 source distribution (sdist)

@jgarzik jgarzik closed this as completed Nov 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants