Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling mistakes, etc. #33

Closed
RenniePet opened this issue Mar 17, 2015 · 1 comment
Closed

Spelling mistakes, etc. #33

RenniePet opened this issue Mar 17, 2015 · 1 comment

Comments

@RenniePet
Copy link
Contributor

I'm evaluating your program, and so far am fairly impressed.

Unfortunately (?), I have ReSharper and ReSpeller installed in my Visual Studio, and they flag all sorts of things that they don't like. And when it comes to spelling mistakes my obsessive-compulsive behavior takes over and I can't help fixing them.

I've submitted a pull request for the ones I've encountered so far that do not result in a breaking change when fixed.

In the Signals folder there is a consistent misspelling of "suppressed", and unfortunately some of them are public names, so fixing them will result in a breaking change for anyone using those parts of that facility. Let me know if you'd like me to submit a pull request for that.

@jgauffin
Copy link
Owner

I'm glad that you made the full request. All contributions are most welcome, no matter if it's spelling corrections or code contributions/corrections.

Feel free to make a pull request for Suppressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants