Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instructions in tutorial2 are incorrect #28

Closed
rplzzz opened this issue Jul 16, 2019 · 0 comments · Fixed by #29
Closed

Instructions in tutorial2 are incorrect #28

rplzzz opened this issue Jul 16, 2019 · 0 comments · Fixed by #29
Assignees

Comments

@rplzzz
Copy link
Contributor

rplzzz commented Jul 16, 2019

In tutorial2 we have the following instructions for training a model in a single step

infileT <- file.path(datadir, 'tas_annual_esm_rcp_r2i1p1_2006-2100.nc')
infileP <- file.path(datadir, 'pr_annual_esm_rcp_r2i1p1_2006-2100.nc')
emulator <- trainTP(c(infileT, infileP), 
                    tvarname = "tas", tlatvar='lat', tlonvar='lon',
                    tvarconvert_fcn = NULL,
                    pvarname = "pr", platvar='lat', plonvar='lon',
                    pvarconvert_fcn = log)

However, in these input files, the names of the latitude and longitude coordinates are actually lat_2 and lon_2 (there are lat and lon variables, but they are length 1 and contain just the single value 0 -- I have no idea why it was generated that way).

Because this code isn't run, the package checks didn't catch the error. If you look further down where we do run the code, step by step, we use the correct versions.

Correction: It's only the tas input that has the funky coordinate names; the pr input has regular names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant