Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report cumulative stats on clones and views #31

Closed
wants to merge 2 commits into from

Conversation

mfry-ll
Copy link

@mfry-ll mfry-ll commented Oct 22, 2021

This PR changes analyze.py in order to produce reports that include cumulative graphs on the unique/total views/clones.

@mfry-ll
Copy link
Author

mfry-ll commented Oct 22, 2021

Feel free to squash and merge rather than keep the history of the multiple commits.

@mfry-ll
Copy link
Author

mfry-ll commented Oct 22, 2021

A few images of the new graphs:
image
image
image
image

@jgehrcke
Copy link
Owner

jgehrcke commented Nov 5, 2021

Hey thank you for the pull request and proposal @mfry-ll!

Can you maybe describe why the cumulative graphs add value, from your point of view? In my opinion, the cumulative count over time is not so much an intuitive representation because the interesting information content is in the slope of that plot. That is why we like to look at the derivative -- where we see how a rate evolves over time.

@mfry-ll
Copy link
Author

mfry-ll commented Nov 9, 2021

@jgehrcke Having a cumulative view provides a complementary perspective to the rate view. Even though both rate and cumulative plots provide all the necessary data (cumulative data can be obtained by integrating the rate plot, and rate data can be obtained by taking the derivative of the cumulative plot), it's convenient to have both plots.

For example, if I want to know exactly how many clones have occurred since a release, that's much easier to see with the cumulative plot, rather than trying to mentally (and inaccurately) integrate that data from the rate plot.

jgehrcke added a commit that referenced this pull request Nov 25, 2021
@jgehrcke
Copy link
Owner

jgehrcke commented Dec 8, 2021

@mfry-ll did you see that in the 1.3.0 release I added the cumulative numbers to the report? I thought that is a nice middle ground, does not consume as much space as the plots that you added, but still puts the information into the report.

@jgehrcke
Copy link
Owner

Closing this for now. Happy to discuss further.

@jgehrcke jgehrcke closed this May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants