fix: improved branch cloning logic

[gautamkrishnar]

improved branch cloning logic. It now checks if the branch exists and uses git cli's --single-branch to improve cloning speed.

[jgehrcke]

Lovely! As you've seen in the code comment above your change I actually wanted to do so. Thanks for tackling the special case. This is tested, I assume? :)

[gautamkrishnar]

Lovely! As you've seen in the code comment above your change I actually wanted to do so. Thanks for tackling the special case. This is tested, I assume? :)

Yep, I am now doing more testing. I Will let you know once I am done.

[gautamkrishnar]

@jgehrcke done testing, updated code to match the existing code style you are using.

[jgehrcke]

Thank you very much for this contribution, and for the splendid communication! Please come back if you have more ideas :).

[flaix]

I might be doing something different than you did in your tests, but this code is not working in my install.
I am also not sure how it could work, because from how I read the code, a command is run under active errexit and then the return code of said command is checked. From my understanding this check will never be reached since the script will exit before it.
But again, I might be doing something different since you said you tested it and it worked for you.
I just wanted to let you know that I had to fix it (flaix/github-repo-stats@51c6353) to make it work.

[jgehrcke]

@jgehrcke done testing

I should not have relied on only that but also should have reviewed a little more carefully. Anyway, we get that sorted out :) Thanks everyone!

[gautamkrishnar]

I should not have relied on only that but also should have reviewed a little more carefully. Anyway, we get that sorted out :) Thanks everyone!

Really sorry for that. Yep, I never saw the set -e I only tested the part I had added. Glad to know that its fixed now.