Fix exit on errexit when return code is used for checks #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the beginning of the script, the return code of `git ls-remote` is used in a check while `errexit` is active. This does not work because in case the `git ls-remote` returns a non-zero code, the script will exit immediately and the line checking the return code in an `if` clause is never reached. For this to work, `errexit` needs to be temporarily disabled and the return code stored in a variable for later use.
Right! It's a common trap which I've hit personally or seen hit many times in the past N years -- I so much miss (Pythonic) context managers for implementing behavior like this. |
|
(for the record, this adds to the patch #32) |
|
@flaix thanks for fixing this 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the beginning of the script, the return code of
git ls-remoteis used in a check while
errexitis active. This does not workbecause in case the
git ls-remotereturns a non-zero code, thescript will exit immediately and the line checking the return code
in an
ifclause is never reached.For this to work,
errexitneeds to be temporarily disabled andthe return code stored in a variable for later use.