Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating a better README #4

Open
jgimeno opened this issue Feb 15, 2017 · 8 comments
Open

Creating a better README #4

jgimeno opened this issue Feb 15, 2017 · 8 comments

Comments

@jgimeno
Copy link
Owner

jgimeno commented Feb 15, 2017

Maybe it could be good to create a README file with information. I wonder if later more technical information and description about the objects should go on the WIKI or inside the README.

@nubeiro
Copy link
Contributor

nubeiro commented Feb 16, 2017

I would suggest adding current value objects and future value objects that will be supported.

For the future value objects I propose:

  • IBAN/Swift/Bic numbers
  • credit card numbers?

@jgimeno
Copy link
Owner Author

jgimeno commented Feb 21, 2017

Let's add this future value objects section.

@sdecandelario
Copy link

Maybe a VO for URL?

@jgimeno
Copy link
Owner Author

jgimeno commented Feb 22, 2017

Let's define what we want for version 1.0

  • Abstract ValueObject, but only this one. Strings is a good object to have even if you only want it as a primitive on steroids. (Done by Daniel Santamaría)

  • Internet Objects
    ----- Host/Domain
    ----- URL

  • Banking objects
    ------ Money
    ------ Currency
    ------ IBAN
    ------ SWIFT CODE
    ------ CardNumber

@sdecandelario
Copy link

ISBN is for books, and IBAN is for banking accounts :)

@jgimeno
Copy link
Owner Author

jgimeno commented Feb 22, 2017

You are absolutely right!! I will edit

@jgimeno
Copy link
Owner Author

jgimeno commented Feb 22, 2017

If you want to take some of the values and create them you are welcome.

@jgimeno
Copy link
Owner Author

jgimeno commented Feb 22, 2017

I have moved all this to

Tasks for release of 1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants