-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pattern ${meta.PATCH_PLUS_COMMIT_DISTANCE} #147
Comments
why do you want to add |
Long story, but it begins with the jpackage not accepting other version numbers than {M].{m}.{p} on Windows (for some other limitations of installation tools used). If I used "auto increase" all commits would add up to the next patch version, until a new tag was set. A valid scheme, but then If I have a lot of patch releases, I'm back to setting loads of tags. With this pattern, one could tag any version (including patch) and have an automatic increase that has the latest patch as baseline and sees any additional commit as a patch on top of that. |
I've created a PR: |
Say I have a version tagged as
1.0.7
Say I have
2 commits on top
of that version.With
${M}.${m}.${p}
and "autoIncrementPatch", I could get was version1.0.8
Using
${M}.${m}.${meta.COMMIT_DISTANCE}
I would get version1.0.2
, which doesn't make sense.It would be nice to have a version pattern like:
${M}.${m}.${meta.PATCH_PLUS_COMMIT_DISTANCE}
effectively giving me version1.0.9
That would respect both the latest patch version of the tag and the commit distance as an increment.
The text was updated successfully, but these errors were encountered: