Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yaml 0.8.32 broke tests #342

Closed
felixonmars opened this issue Jul 10, 2018 · 1 comment

Comments

@felixonmars
Copy link
Contributor

commented Jul 10, 2018

Updating to yaml 0.8.32 seems to break the test suite of pandoc-citeproc with errors like:

--- expected    2018-07-10 16:35:57.989475894 +0800
+++ actual      2018-07-10 16:35:57.989475894 +0800
@@ -15,3 +15,3 @@
   publisher-place: Location
-  page: '100-200'
+  page: 100-200
   volume: '3'
@@ -33,3 +33,3 @@
   publisher-place: Location
-  page: '100-200'
+  page: 100-200
   volume: '3'
[biblio2yaml/maron.biblatex] PASSED
[biblio2yaml/basic.bibtex] FAILED
--- expected    2018-07-10 16:35:58.222809766 +0800
+++ actual      2018-07-10 16:35:58.222809766 +0800
@@ -22,3 +22,3 @@
   container-title: Journal of Generic Studies
-  page: '33-34'
+  page: 33-34
   volume: '6'
119 passed; 44 failed; 0 skipped; 0 errored.

I assume it can be safely skipped, though.

@jgm

This comment has been minimized.

Copy link
Owner

commented Oct 12, 2018

Fixed now; we just require yaml >= 0.8.32 and updated the test suite.

@jgm jgm closed this Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.