Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--self-containted not working with reveal.js themes #2373

Closed
kmindi opened this issue Aug 26, 2015 · 9 comments
Closed

--self-containted not working with reveal.js themes #2373

kmindi opened this issue Aug 26, 2015 · 9 comments

Comments

@kmindi
Copy link

kmindi commented Aug 26, 2015

It seems that using the --self-contained option does not work with the theme blood.

pandoc 1.15.0.6
reveal.js 3.1.0
commandline used (not working): pandoc -S --self-contained -s -f markdown -t revealjs -i -V theme:blood -o presentation.html presentation.md

Expected from the theme blood is a black background, instead it appears white.

see also hakimel/reveal.js#1330

@KurtPfeifle
Copy link

It would be really, really nice and helpful (for yourself as well as anybody who tries to help solve your problem), if you could state:

  1. The Pandoc version you are using (_meanwhile DONE_, thanks)
  2. The RevealJS version you are using (_meanwhile DONE_, thanks)
  3. The exact, complete pandoc --to=revealjs... command line you are using (_meanwhile DONE_, thanks)
  4. A rough description of what exactly does not work with the theme (what do you expect, and what comes out instead?) _(TO BE DONE)_

BTW, your link to the issue 1330 is not correct (_now CORRECTED_, thanks). The RevealJS creator's username is hakimel, not akimel, so the link should be:

@KurtPfeifle
Copy link

I can confirm this problem for:

  • Pandoc v1.15.0.6 (on OS X 10.10.5 Yosemite)
  • RevealJS 3.1.0
  • Themes: _beige, league, blood, night_

The other themes (default, white, black, solarized, moon, simple, sky) seem to be fully working. (There may be things which I haven't noticed when taking my quick look.)

What is obvious about the faulty themes: the _slide backgrounds are not correct_. (There may be other glitches which I haven't noticed.)

@jgm
Copy link
Owner

jgm commented Oct 6, 2015

Do you have a suggested fix? What exactly should be changed
in the default revealjs template?

+++ Nicolas Borboën [Oct 06 15 03:33 ]:

[1]https://github.com/hakimel/reveal.js/releases/tag/3.0.0
Minified files (reveal.min.js and reveal.min.css) are no longer tracked
in the repo

@jgm
Copy link
Owner

jgm commented Oct 6, 2015

+++ Nicolas Borboën [Oct 06 15 09:35 ]:

And a real solution would be to change these path in pandoc src.

Yes, I was asking about the real (best) solution.
Can you tell me what exactly in data/templates/default.revealjs
should be changed?

@jgm
Copy link
Owner

jgm commented Oct 6, 2015

Your pandoc version is too old. You should upgrade to
the latest. There are binary packages available if you
don't want to install from source.

+++ Nicolas Borboën [Oct 06 15 10:09 ]:

Sorry, but for my pandoc version (pandoc 1.12.4.2 / reveal 3.1.0) none
of the 11 themes seems to work. I used the same cmd pandoc -S
--self-contained -s -f markdown -t revealjs -i -V theme:blood -o
presentation.html presentation.md

Themes list:
* css/theme/black.css
* css/theme/white.css
* css/theme/league.css
* css/theme/sky.css
* css/theme/beige.css
* css/theme/simple.css
* css/theme/serif.css
* css/theme/blood.css
* css/theme/night.css
* css/theme/moon.css
* css/theme/solarized.css

My link to the style sheet looks like:

@ponsfrilus
Copy link

Sorry for the noise here - I'll remove my useless messages.

I create a PR hakimel/reveal.js#1387 for hakimel/reveal.js#1330 - it fix the blood template background.

@jgm
Copy link
Owner

jgm commented Oct 21, 2015

I'm unclear whether there's still an issue here with pandoc (as opposed to the themes).
Can someone clarify this?

@kmindi
Copy link
Author

kmindi commented Oct 21, 2015

The background seems to be fixed if I apply the css code from @ponsfrilus pull request hakimel/reveal.js#1387.
But there is still a difference at least in the font when I use --self-contained:

2015-10-21_08-05-09

The css looks the same though.. Maybe there is a rendering bug in firefox/chrome not applying the specified font from the data uri data:text/css:...; or there is a css difference after compressing and base64-encoding.

(using pandoc 1.15.1.1 and reveal.js at hakimel/reveal.js/commit/34b82baa6724a336ede020b33e1bd002529def18 ahead of 3.1.0)

@jgm
Copy link
Owner

jgm commented Nov 1, 2015

@kmindi I've recently applied a patch that fixes a bug in data uris in CSS. I suspect this might fix the issue you note in your last comment. If you can compile the latest development version from source, can you test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants