Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make --self-contained able to fetch from https urls #820

Closed
jgm opened this issue Apr 6, 2013 · 3 comments
Closed

Make --self-contained able to fetch from https urls #820

jgm opened this issue Apr 6, 2013 · 3 comments

Comments

@jgm
Copy link
Owner

jgm commented Apr 6, 2013

As the title says.
Currently an error is raised.

@jgm
Copy link
Owner Author

jgm commented Apr 8, 2013

Here are the options:

  • automatically fall back to http (drawbacks: bad practice to make insecure requests when secure ones are requested, may not always be a fallback)
  • use http-conduit (simple, but draws in a huge number of dependencies)
  • use network-curl (simple, but requires libcurl C library, which may cause installation difficulties, esp. on Windows)
  • just call the wget or curl command line program in shell

I don't love any of these, but it would be good to support https somehow. Is there an option I've missed?

@chloerei
Copy link

I hope odt and docx writer can fetch images from https urls too.

@jgm
Copy link
Owner Author

jgm commented Jul 4, 2013

On reflection, I think the best solution is to add a cabal flag https; if set, http-conduit will be added as a dependency and used; otherwise, the standard http library will be used.

@jgm jgm closed this as completed in ed714b1 Jul 5, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants