Separate out T.P.Data, T.P.Translations from T.P.Class. #8348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes T.P.Class more self-contained, and suitable for extraction into a separate package if desired. [API changes] - T.P.Data is now an exported module, providing `readDataFile`, `readDefaultDataFile` (both formerly provided by T.P.Class), and also `getDataFileNames` (formerly unexported in T.P.App.CommandLineOptions). - T.P.Translations is now an exported module (along with T.P.Translations.Types), providing `readTranslations`, `getTranslations`, `setTranslations`, `translateTerm`, `lookupTerm`, `readTranslations`, `Term(..)`, and `Translations`. - T.P.Class: `readDataFile`, `readDefaultDataFile`, `setTranslations`, and `translateTerm` are no longer exported. `checkUserDataDir` is now exported. - Text.Pandoc now exports Text.Pandoc.Data and `setTranslations` and `translateTerm`.
|
I'd also like to consider breaking up T.P.Shared, so T.P.Class doesn't depend on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes T.P.Class more self-contained, and suitable for extraction into a separate package if desired.
[API changes]
T.P.Data is now an exported module, providing
readDataFile,readDefaultDataFile(both formerly provided by T.P.Class), and alsogetDataFileNames(formerly unexported in T.P.App.CommandLineOptions).T.P.Translations is now an exported module (along with T.P.Translations.Types), providing
readTranslations,getTranslations,setTranslations,translateTerm,lookupTerm,readTranslations,Term(..), andTranslations.T.P.Class:
readDataFile,readDefaultDataFile,setTranslations, andtranslateTermare no longer exported.checkUserDataDiris now exported.Text.Pandoc now exports Text.Pandoc.Data and
setTranslationsandtranslateTerm.