Textile reader: Add support for link references #8706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Textile supports what it calls "link alias", which are analogous to Markdown's reference-style links. During the parser's first-pass, we can collect link references in addition to footnotes. Textile differs from Markdown in that reference definitions don't have titles nor attributes, so the stored values in `stateKeys` is relatively sparse.
alts
changed the title
|
thanks and sorry for the belated merge! |
|
@jgm No worries! Thank you so much for the work you do maintaining this! If there's anything I can do to make the PRs easier to review or merge, please let me know. I anticipate making a few more upgrades to the Textile parser as I bump into discrepancies while I port a project of mine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Textile supports what it calls a "link alias", which is analogous to Markdown's reference-style links.
During the parser's first-pass, we can collect link references in addition to footnotes. Textile differs from Markdown in that reference definitions don't have titles nor attributes, so the stored values in
stateKeysis relatively sparse.I modeled the parser after the Markdown, and the new test cases are passing, but let me know if there's anything essential from Markdown's reference parsing that I missed.