Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with HTML tags - fail to copy book to device #45

Closed
riedje opened this issue May 18, 2013 · 5 comments
Closed

Issue with HTML tags - fail to copy book to device #45

riedje opened this issue May 18, 2013 · 5 comments
Labels

Comments

@riedje
Copy link

riedje commented May 18, 2013

Calibre version: 0.9.31-x64 (Windows)
Plugin version: 1.3.2
Device: Kobo Aura HD (firmware 2.5.2)

Tag combinations such as <p><b><br /></b></p> cause the driver to emit an error.
I've created a new EPUB with Sigil and pasted this particular tag combination to isolate the issue, this book is available to be sent if you so desire.

Please note that other combinations similar to this one also cause errors, if I encounter them again I'll be sure to mention them. They do seem to have in common that there's no text within the innermost tags and/or the different style of tag notation: <tag> ... </tag> vs. <tag />.

@jgoguen
Copy link
Owner

jgoguen commented May 18, 2013

Please post a link to the file. I'll happily take a test book duplicating the issue, especially if you've got one book with a few different examples of problematic combinations.

@riedje
Copy link
Author

riedje commented May 19, 2013

You can download the test epub from here: https://dl.dropboxusercontent.com/u/31409399/testbook.epub
If (when) I encounter other epubs (unfortunately I already fixed the older ones manually) I'll send them over right away!

@jgoguen
Copy link
Owner

jgoguen commented May 19, 2013

It looks like there's an issue with the HeuristicProcessor class in calibre. I'll try to narrow down what exactly is wrong and file a bug report against calibre.

@riedje
Copy link
Author

riedje commented May 19, 2013

Another snippet that generates an error:
<p class="also-by-title"><i>STORM FRONT<br /> FOOL MOON<br /> GRAVE PERIL<br /></i> Available from Roc Books</p>

After playing around a bit with the HTML it looks like the error occurs when the <br /> tag is followed immediately by the </i> tag. If text is placed between those two tags, the file conversion is successful.

@jgoguen
Copy link
Owner

jgoguen commented May 19, 2013

Same issue. I've filed a bug report (https://bugs.launchpad.net/bugs/1181873) and I'll come up with a workaround in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants