Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Travis builds are failing while pip-review actually works #15

Closed
jgonggrijp opened this issue Oct 27, 2016 · 3 comments · Fixed by #37
Closed

Travis builds are failing while pip-review actually works #15

jgonggrijp opened this issue Oct 27, 2016 · 3 comments · Fixed by #37
Milestone
Version 1.0

Comments

@jgonggrijp
Copy link
Owner

If you find a way to repair the tests, please submit a pull request!
@ghost
Copy link

ghost commented Nov 4, 2016

Is there a particular reason that Python26 is still supported?

@jgonggrijp
Copy link
Owner Author

No, except that it still appears to work. As long as it works without additional effort, I intend to support it. But given that choice, I believe some work to repair the test is justified.

This was referenced Jan 15, 2017
Merged
Closed
@Flimm Flimm mentioned this issue Jan 20, 2017
Merged
@jgonggrijp
Copy link
Owner Author

jgonggrijp commented Jan 20, 2017 •
edited
Loading

cElementTree is in the tests because of ## FIXME: output in pip freeze (see nvie#9). When #32 is resolved, we won't be using pip freeze anymore, so cElementTree can be removed from the tests. That will remove the barrier to including Python 3 in the Travis build. Credits to @Flimm for research conducted in #34.

@jgonggrijp jgonggrijp added this to the Version 1.0 milestone Jan 20, 2017
@jgonggrijp jgonggrijp mentioned this issue Jan 23, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 1.0
Development

Successfully merging a pull request may close this issue.

Ignore Python 2.6 deprecation notice in tests Flimm/pip-review
1 participant
@jgonggrijp