This repository has been archived by the owner on Nov 13, 2020. It is now read-only.
Fix issue #71 (endless loop in mxHierarchicalLayout) #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(changes ported from mxgraph/javascript/src/js/layout/hierarchical/mxHierarchicalLayout.js)
|
The fix works for me to. |
hoijui
approved these changes
May 28, 2020
Comment on lines
+487
to
+491
| // Check whether there are more edges incoming from the target vertex than outgoing | ||
| // The hierarchical model treats bi-directional parallel edges as being sourced | ||
| // from the more "sourced" terminal. If the directions are equal in number, the direction | ||
| // is that of the natural direction from the roots of the layout. | ||
| // The checks below are slightly more verbose than need be for performance reasons |
Comment on lines
+414
to
+415
| // Ignore ports in the layout vertex list, they are dealt with | ||
| // in the traversal mechanisms |
| @@ -456,19 +466,51 @@ protected void traverse(Object vertex, boolean directed, Object edge, | |||
|
|
|||
| int edgeCount = model.getEdgeCount(vertex); | |||
|
|
|||
| boolean[] edgeIsSource = new boolean[edgeCount]; | |||
There was a problem hiding this comment.
maybe add a comment like: "// caching for performance reasons"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes were ported from mxgraph/javascript/src/js/layout/hierarchical/mxHierarchicalLayout.js. I don't really understand this layouting algorithm, so please double-check my code.
Fix is mainly located in traverse function, but I also found a difference in filterDescendants function between Java and JS versions.
You can find sample XML graphs that are causing endless loop in issue #71 description