New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added storybook with button component #58
Conversation
Very happy to see this! Reviewing... |
Ahh, I put the folder in .eslintignore temporarily to get the commits in, but I'll remove it from the file and see what the behavior is like after your commit. Should be ready to merge after that. Thanks for the help! |
I'm okay with not linting the stories directory as storybook is mostly for viewing components and visual testing. If linting doesn't cause extra work, I'm ok with enabling it. EDIT: Also, with VSCode, linting and formatting on file save are very helpful features. This files should be detected by vscode and recommend installations https://github.com/jgresham/nice-node/tree/main/.vscode |
Two suggestions (If you could fix first for this PR that'd be ideal):
|
Great work!! I know config for webpack can be troublesome and hard to debug, so thanks for getting that in here. It's great to see the redesigned button in here too! The latest commit here is deployed at https://nndesign.netlify.app/ |
This PR adds storybook to the project (along with 2 other default story files included with initialization as reference for now), and a button component based on the current draft specs. Currently only includes 2 icons. Wasn't exactly sure what kind of templates we wanted for stories, but made them based on sizes for now.
@jgresham Do you happen to know what's going on with the typescript errors with the Github Actions? I'm still new with TypeScript, and I looked it up, but it's having issues with the Storybook generated files.. I thought about ignoring these files but that doesn't seem like a good idea either 🤔
resolves #54