error: redefinition /previous definition of 'class HTTPClient'

[frogg1ven]

Hi,
I'm using your library in my project along with ESP8266HTTPClient library, and there is colision between them, that I can't fix.
I have this errors:
...\RadioLib-master\src/protocols/HTTP/HTTP.h:18:7: error: redefinition of 'class HTTPClient' class HTTPClient { ^ ...\ESP8266HTTPClient\src/ESP8266HTTPClient.h:163:7: error: previous definition of 'class HTTPClient' class HTTPClient ^
I have read, that libraries need something like this:
#ifndef libName_h #define libName_h class HTTPClient{ ... } #endif
and I tried to fix this, but it doesn't seem to work, and both libraries has similar things already defined.
Could you help me with this problem?

[jgromes]

What you're referring to is called a macro guard, and RadioLib has those:

RadioLib/src/protocols/HTTP/HTTP.h

Lines 1 to 2 in 9ac6503

	#if !defined(_RADIOLIB_HTTP_H)
	#define _RADIOLIB_HTTP_H

However, the actual issue is a clash of the same name for different classes - both RadioLib and ESP8266HTTPClient have class named HTTPClient.

Fortunately, RadioLib has quite a clever way to exclude drivers for different modules. I excluded HTTP support from RadioLib on ESP8266 platform in the latest commit (since HTTP support in RadioLib is quite basic and likely offers no advantages over ESP8266HTTPClient), so it works now.

[frogg1ven]

thanks for help. it works now!

[HamzaHajeir]

Thanks @jgromes, I just had this error, I'm wondering when this would be released (as library version)?

Thanks

[jgromes]

I guess there's no reason to not release, it's been a while and it looks like there's no major changes coming in the near future.