Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix code #6

Open
3 of 5 tasks
jh0ker opened this issue May 16, 2016 · 8 comments
Open
3 of 5 tasks

fix code #6

jh0ker opened this issue May 16, 2016 · 8 comments
Assignees

Comments

@jh0ker
Copy link
Owner

jh0ker commented May 16, 2016

Clearly, the issue title is to be understood with a little bit of irony...

The code I have written for this bot is horrible. The reason is that in the beginning, this was merely a proof-of-concept and a fun-project.
Now that the bot is AGPL-Licensed, I'd like to get this thing ready to be understood by others:

  • So they actually have a chance to do something with their fork
  • To allow them to contribute to this project

Things to do:

  • Clearly seperate game logic from Telegram interface
  • Get rid of all those pesky (almost-)repetitions I did out of laziness
  • Translation support
  • Unit tests
  • Proper code documentation

The only help I'm asking from you right now is to point out more issues in the code :)

@jh0ker jh0ker self-assigned this May 16, 2016
@jh0ker jh0ker mentioned this issue May 16, 2016
@TiagoDanin
Copy link
Contributor

  • Mult-language support

@jh0ker
Copy link
Owner Author

jh0ker commented May 16, 2016

@TiagoDanin Yes!

@jh0ker
Copy link
Owner Author

jh0ker commented May 17, 2016

I'm also adding some user statistics with this. Currently I have

  • Nr. of games won in first place
  • Nr. of games completed
  • Nr. of cards played

Any more ideas?

@TiagoDanin
Copy link
Contributor

  • Nr. of cards special played

@jh0ker
Copy link
Owner Author

jh0ker commented May 17, 2016

@TiagoDanin How about saving statistics per card, so we can filter later as needed? Not sure how bad the db structure will look then tho ^^

@jh0ker
Copy link
Owner Author

jh0ker commented May 17, 2016

@TiagoDanin Or maybe not... It'd be horrible :D

@jh0ker
Copy link
Owner Author

jh0ker commented May 19, 2016

Commit 620486 is a massive change (14 changed files with 762 additions and 346 deletions)
Some unit tests have been added, and I'll be working on more.

This was referenced May 19, 2016
@jh0ker
Copy link
Owner Author

jh0ker commented May 21, 2016

Translations are now working :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants