Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for projects in organizations #16

Merged
merged 1 commit into from Oct 17, 2021
Merged

Conversation

Seldom-SE
Copy link
Contributor

@Seldom-SE Seldom-SE commented Oct 12, 2021

I renamed repo_owner to username, so the terminology would fit these changes. This is a breaking change!

Also, I made it so that the tool looks for an organization if repo_name is left empty. Unfortunately, users may have to read the docs to understand this. Feel free to make suggestions or contributions for this.

I have updated the docs to reflect these changes.

Closes #14

@thehale
Copy link
Owner

thehale commented Oct 12, 2021

There might also be a way to directly look up the project without going through the organization/user.

This could also allow us to use the REST API instead of the GraphQL API which would mean that public repos wouldn't require a personal access token to generate a bit down chart.

Relevant API documentation:
https://docs.github.com/en/rest/reference/projects#get-a-project

@Seldom-SE
Copy link
Contributor Author

It looks like each project has a unique ID associated with it, which is what is used in the API. However, as far as I could tell, there is no way for a user to find this ID on GitHub. So, even if we used the REST API, the user would still have to deal with organizations/users. I'm not sure what that would mean for the personal access token, though.

@thehale thehale changed the base branch from main to dev October 16, 2021 21:20
thehale added a commit that referenced this pull request Oct 17, 2021
PR #16 was opened before the latest refactor. This commit
integrates it's changes into the current code base.

Also closes #15
@thehale thehale merged commit 77230e0 into thehale:dev Oct 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[enhancement] Support for organizations' projects
2 participants