-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compilation with target Java 5 #31
Comments
I don't think there's any strong reason why 1.6, mostly just because 1.5 is so old :) I'll have a look at dropping down to 1.5. |
FYI: RabbitMQ Java client 3.4 likely won't support JDK 5 any more. |
Thanks for the info Michael. @mladenmarkov I think I'll have to hold off on 1.5 support in that case. I hate that this means leaving potential users such as yourself behind, but Lyra needs to be able to keep up with the amqp-client as it moves forward. |
@jhalterman doing one Lyra release that is JDK 5 compatible and depends on amqp-client 3.3.0 is a reasonable request. 3.4 is 3-4 months away. |
Thanks guys for the comments. |
@mladenmarkov Not only would it be bound to amqp-client 3.3, but you'd be stuck on that Lyra version as well. I don't have any big changes planned or anything, but it's something worth mentioning. |
Yes, I'm aware of that, thanks. |
Hey
You have the source and target versions set to 1.6 in the pom.xml which naturally results in building Java 6 classes. I just tried changing it to 1.5 and the project compiled successfully, and all tests pass.
RabbitMQ Java client is also compiled for Java 5.
Is there a particularly strong reason to require Java 6?
I am still bound to Java 5 in my project and I need to use Lyra as it fits awesomely to it. I'd very much like to consume it from Maven central, rather than having built my own copy.
Would you consider that, please?
Thanks.
Cheers
Mladen
The text was updated successfully, but these errors were encountered: