Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sun.reflect optionality in OSGi manifest #31

Open
yrashk opened this issue Oct 20, 2016 · 2 comments
Open

sun.reflect optionality in OSGi manifest #31

yrashk opened this issue Oct 20, 2016 · 2 comments

Comments

@yrashk
Copy link

yrashk commented Oct 20, 2016

Hi Jonathan,

This issue is in reference to npgall/cqengine#94

If typetools marked sun.reflect as an optional package in its OSGi manifest, then in case when its functionality required, one would need to follow the OSGi instructions (as per README) the same way as before.

However, in cases when typetools is a transient dependency (cqengine, for example, depends on it for a small part of its functionality), it is useful when this functionality is not going to be used and therefore there is no need to add sun.reflect to extras.

What do you think?

@jhalterman
Copy link
Owner

@yrashk I saw that discussion... I'm not an OSGi user myself, but I'd be fine with marking sun.reflect as optional (or taking a pull request along those lines) so long as it could still be manually imported and verified that things work as expected.

I assume that cqengine just doesn't need lambda type arg resolution (which the sun.reflect code is used for) ?

@npgall
Copy link

npgall commented Oct 27, 2016

Hi Jonathan, currently CQEngine has its own code for detecting generic types in non-lambda objects, and it's only using typetools for the lambda support actually.
But going forward I plan to remove the remaining code in CQEngine and to use typetools for the non-lambda stuff too. Thanks for TypeTools it's really a great library btw!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants