Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source code layout #16

Closed
luizvarela opened this issue Jan 24, 2017 · 3 comments
Closed

Source code layout #16

luizvarela opened this issue Jan 24, 2017 · 3 comments
Milestone

Comments

@luizvarela
Copy link
Collaborator

One thing that I noticed is the four spaces in the generated models, following the Elixir style guide, two spaces are preferred. Also, the lib code is using 4 spaces too.
I think we can start changing the Ecto models first and then the entire source code. What do you think?

https://github.com/christopheradams/elixir_style_guide#source-code-layout

@jhartwell
Copy link
Owner

Good idea. It should be an easy fix for the models as there is a helper function that formats. Feel free to make the change if you want

@jhartwell
Copy link
Owner

The model changes have been checked in #18

@jhartwell jhartwell added this to the 1.2.0 milestone Jan 25, 2017
@jhartwell
Copy link
Owner

Changes have been checked in to release 1.2 branch

@jhartwell jhartwell modified the milestones: 2.0, 1.2.0 May 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants