Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript definition #19

Closed
maxpaj opened this issue May 1, 2018 · 1 comment
Closed

Typescript definition #19

maxpaj opened this issue May 1, 2018 · 1 comment

Comments

@maxpaj
Copy link

maxpaj commented May 1, 2018

Would be really nice to have a typescript definition for this.

Is there some documentation from where I can copy all of the definitions?

BTW: Amazing library you've created, I've had a lot of use for it :)

@jhermsmeier
Copy link
Owner

Thanks for the kind words, very appreciated! :)

While I understand the need & usefulness of type definitions, I'm afraid I'd rather not add them, as I'm not a TypeScript user myself, and would most likely fail at maintaining them properly.

Unfortunately, documentation is lacking as well – your best bet will be combing through the code (which isn't a lot (~200 LOC), but a bit convoluted). I've been planning to give this some more work, but time is a limiting factor.

That said, I'd still be happy to accept a PR adding them, if you'd like to give it a go. Alternatively typings could be added over at DefinitelyTyped, I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants