Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toString() produces cards with \n, not \r\n #33

Closed
bengotow opened this issue Oct 6, 2019 · 2 comments
Closed

toString() produces cards with \n, not \r\n #33

bengotow opened this issue Oct 6, 2019 · 2 comments
Assignees
Labels

Comments

@bengotow
Copy link

bengotow commented Oct 6, 2019

Code to reproduce:

let vcf = <a card>

// Parse into vCard
const card = new vCard().parse(vcf);

// Serialize back to string
vcf = card.toString()

// Throws an exception because newlines in new vcf string are `\n` and the parser expects `\r\n`
const card = new vCard().parse(vcf);
@jhermsmeier jhermsmeier added the bug label Oct 6, 2019
@jhermsmeier jhermsmeier self-assigned this Oct 6, 2019
@jhermsmeier
Copy link
Owner

Thanks! That was an embarassing bug 😄
Fix published in vcf@2.0.6

@bengotow
Copy link
Author

bengotow commented Oct 6, 2019

Wow thanks for the quick turnaround, that's awesome! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants