Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Created MlpGenerator and a superclass #286

Merged
merged 6 commits into from Nov 3, 2018
Merged

Conversation

droidadroit
Copy link
Contributor

@droidadroit droidadroit commented Nov 2, 2018

This pull request resolves #285

The pull request is ready to be merged.

The details of the pull request:
Created a class MlpGenerator consistent with the already existing CnnGenerator. Created a superclass NetworkGenerator inherited by CnnGenerator and MlpGenerator.

@coveralls
Copy link

coveralls commented Nov 2, 2018

Pull Request Test Coverage Report for Build 838

  • 26 of 29 (89.66%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 94.795%

Changes Missing Coverage Covered Lines Changed/Added Lines %
autokeras/nn/generator.py 23 26 88.46%
Files with Coverage Reduction New Missed Lines %
autokeras/bayesian.py 2 95.85%
Totals Coverage Status
Change from base Build 811: -0.2%
Covered Lines: 2149
Relevant Lines: 2267

💛 - Coveralls

@droidadroit droidadroit changed the title [WIP] Created MlpGenerator and a superclass [MRG] Created MlpGenerator and a superclass Nov 2, 2018
@droidadroit droidadroit changed the title [MRG] Created MlpGenerator and a superclass [WIP] Created MlpGenerator and a superclass Nov 2, 2018
@droidadroit droidadroit changed the title [WIP] Created MlpGenerator and a superclass [MRG] Created MlpGenerator and a superclass Nov 2, 2018
Copy link
Member

@haifeng-jin haifeng-jin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@haifeng-jin haifeng-jin merged commit 757d5e5 into master Nov 3, 2018
@haifeng-jin haifeng-jin deleted the mlpgenerator branch November 3, 2018 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a class to generate an MLP
3 participants