-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub Action for unit tests #14
Comments
While I though initially that using a premade github action would be trivial, it's not here. There's a big problem with CI/CD of graphical libraries: The only option to run tests as they stand currently would be a self-hosted action on a machine that has both an It is certainly to separate tests for individual internal functions out into headless tests, but the meat and potatoes is going to have to be on a graphics capable computer. As an extension to that, there could be graphical tests. This could include things like:
It's doable, but difficult. The test suite could get pretty annoying to click through that way too... |
This is obviously much more difficult than I thought, thanks @AstroFloof for exploring this. We can consider automating GUI tests with the self-hosted option using something like Squish, but...that really has nothing to do with getting the current test suite to run in CI/CD. What needs to happen for this particular issue is for Starlight and/or Telescope and/or the tests themselves to be modified to run successfully in a headless environment. Automated GUI tests can come later. |
Given the existence of #25 maybe this can run headlessly, but it just doesn't run at all right now. |
I don't think that issue is related to this one. At least I hope it isn't. In any case there's no reason why SDL and Vulkan can't run headlessly, they have various features to support that use case, it's just a question of how to make it happen. Hence the increased bounty. |
I'm taking immediate responsibility for this since it affects the contribution workflow so much. I'm going to make the necessary modifications to Telescope and take care of the GitHub workflows. The rest of you can take it easy wrt this issue. |
Sounds good! |
Money saved is money earned, so ya pretty much. :) |
Running the test suite should be part of our CI/CD setup.
The text was updated successfully, but these errors were encountered: