Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update All Daily Build OS to Ubuntu 18.04 #10662

Closed
1 task done
SudharakaP opened this issue Oct 21, 2019 · 7 comments · Fixed by hipster-labs/jhipster-daily-builds#27
Closed
1 task done

Update All Daily Build OS to Ubuntu 18.04 #10662

SudharakaP opened this issue Oct 21, 2019 · 7 comments · Fixed by hipster-labs/jhipster-daily-builds#27

Comments

@SudharakaP
Copy link
Member

Overview of the issue

This was inspired from the following thread; hipster-labs/jhipster-daily-builds#25. I think we should consider upgrading all daily builds to Ubuntu 18.04 (i.e: ubuntu-latest) image.

If this is in agreement I can do a pull request. 😄

Motivation for or Use Case

We had some success with hipster-labs/jhipster-daily-builds#25 after upgrading to Ubuntu 18.04 and I also think we should make all the builds consistent. Given that we user ubuntu-latest on our Github CI, I think it makes sense to upgrade.

Suggest a Fix

Upgrade all vmImage tags to ubuntu-latest

  • Checking this box is mandatory (this is just to show you read everything)
@pascalgrimaud
Copy link
Member

agree, we should use Ubuntu LTS

@pmverma
Copy link
Member

pmverma commented Oct 21, 2019

@pascalgrimaud I also would like to have a schedule for Windows which is already available in daily-build. I know the build was not stable but it would be better to enable and watch.

@SudharakaP
Copy link
Member Author

SudharakaP commented Oct 21, 2019

@pmverma : Agreed.

I can do this as part of this as well if you guys are okay with it. What specific configuration(s) shall we use. How about a basic monolith with all the defaults? Or do you have a different specification in mind? 😄

Or shall we have multiple windows builds with several different configurations? Wonder whether it will become a maintenance overhead in this case though. 😄

@pmverma
Copy link
Member

pmverma commented Oct 21, 2019

Sorry for confusing you. I meant to have a schedule under daily-build, not the main generator build.
We already have a Windows pipeline at
https://github.com/hipster-labs/jhipster-daily-builds/blob/master/azure-pipelines-official-windows.yml
https://github.com/hipster-labs/jhipster-daily-builds/blob/master/azure-template-windows.yml
I think @pascalgrimaud has the permission to configure the azure pipeline.

Notes:
Unfortunately writing PowerShell or batch script using yml was a hell and I finally decided to use the git bash to run the script in the pipeline.
So you will see minimal to no difference between the Linux and windows pipeline.

Edit:
updated link

@SudharakaP
Copy link
Member Author

@pmverma : Ah, no problem. Got it; thanks for the info 😄

@SudharakaP
Copy link
Member Author

I've created the pull request to upgrade all pipelines; let me know if you see any issues. I'll monitor this for sometime to see if everything works as expected. 😄

@SudharakaP
Copy link
Member Author

SudharakaP commented Oct 23, 2019

I've missed one step in my previous PR. We have to upgrade ChromeDriver as well since the default ChromeDriver seems not compatible with Chrome 78 which we install in the build scripts. I've created a new PR for this one. 😄

@pascalgrimaud : Could we restart all daily builds to check if everything works as expected after we merge hipster-labs/jhipster-daily-builds#29 and #10673 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants