-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce the side by side option #12497
Comments
For the repository and service, I believe it's easier to do side-by-side by extending the repository generated by JHipster and setting |
Hi @cbornet , Tried this, but spring doesn't like it: it forces to have only one repository by entity... So @norepositorybean is mandatory for the actual generated repository. For service I forgot the annotation: |
Any updates @Tcharl? |
Should we include this in the main generator? |
@Tcharl do you want to merge #12521?
|
@mshima yes please I would be very glad to see it in the current patch release. What about simplifying the usage:
So that both files will stay relevant even after the yeoman upgrade |
I am against jhipsterignore, because of the reasons I explained in the issue, like this will not work for modules. |
This issue is stale because it has been open 30 days with no activity. |
This issue is stale because it has been open 30 days with no activity. |
Hi. Any progress on Side-by-side generator? |
Hi @joro88 , Not really: I'm on the constants part for now, because I think that simplifying the generator will help to introduce new options... After that constant and some refactor of some weird generator stuff, I plan to go for #14363 then this one. |
Wow this is a hidden gem, I could not find a doc about it and expected format. |
It's as simple as that.
I just don't know where to add the doc |
For JHipster, it could be in tips section. |
Thank you for pointing out. This sounds convenient. |
@gmarziou I have my own base classes for both the entities and DTOs that JHipster generates. I wrote a shell script that adds them/patches them back into the source code after JHipster updated my entities. The same applies to the Spring Data repository interfaces: For some, I created my own repository interface. My shell script then appends these to the existing |
@ksilz interesting, and for how long did you update your project with the generator since initial generation? |
@gmarziou Since Feb 2020. JHipster updates (like 6.x going to 7.x) are still a royal freakin' pain the butt. But I can update my entities effortlessly. What also helps is that I don't use the default Angular UI. I built my own, so no conflicts there. And I got my own business layer on top of JHipster. |
Major upgrades are painful and I consider it's not worth. On my team's projects, we never used JHipster more than few weeks, I prefer to cut all dependencies from JHipster as soon as possible so that I can upgrade dependencies more easily and feel free to refactor our code. |
@gmarziou I stick with JHipster.
|
@ksilz Upgrading Spring Boot for JHipster is a major effort each time for the team because it has to work on so many project configurations. It is much simpler for your own projects that have a narrower scope, this is why I don't use JHipster BOM as I must be more reactive to update deps to be compliant with PCI-DSS requirements. |
@gmarziou I understand that it's a major effort. I'm not asking to get major versions faster (like 2.5 right now and 3.0 in the fall). What I do want is faster security fixes. An example: We were stuck with Spring Boot 2.2.7, I think, before JHipster 7.0 was out. Now at that time, the 2.2 branch was at 2.2.12 or something, 5 patches ahead. That's a lot of bug fixes and security updates we were missing in Spring Boot, plus all the related projects (Spring Security, Spring Data, ...). So how can we speed this up? From what I can see on the outside, there's no "patch branch in parallel to next major version" going on at JHipster. I think that's one of the reasons why people stop using JHipster quickly and switch to manual mode. At the very least, I'd like to have documentation for a "manual Spring Boot override": Let me, in my own little project here, switch from "JHipster Spring Boot 2.2.7" to "My own Spring Boot 2.2.12", for instance. |
Even Spring Boot team lags behind sometimes in terms of security updates, I had recently the case with Undertow. In the end, security updates are the responsibility of the app dev team. I like your proposal to have documentation for a "manual Spring Boot override", I did it once for one of my projects and I found it not that easy but I can't remember the details, this was the trigger for me to depend directly on Spring Boot rather than through JHipster's indirection. |
@gmarziou Who would know how to do a "manual Spring Boot override"? |
Only those who tried recently, please contribute. |
Hi, |
Tips page created and review pending: jhipster/jhipster.github.io#1171 |
Closing since documentation has been added as a tip |
Overview of the feature request
We propose to add a jhipster 'side by side' application binary option (
sidebyside * exept D
) generating code differentlylet's take that jdl as an example:
Motivation for or Use Case
Jhipster is generating classes that are directly used and that cannot be customized easily: any regeneration will lead to either a merge step or custom code erase. Thus, upgrading or generating is a dangerous step to achieve, leading to project stop using the platform.
Related issues or PR
Antonio Goncalves presentation @ jhipster conf 2018
The text was updated successfully, but these errors were encountered: