-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Buttons have black text on colored background #18008
Comments
This is related to bootstrap 5. |
If that's the case, should we close this issue? |
IMO white would look better for current colors, but I don’t know if it’s possible to do it for every component, without customization every component one by one. |
@mraible I created a project with jhipster 7.7.0 and I didn't have this issue. Im using React. |
@hamaarouf It looks like your blue buttons have a brighter background than mine, so maybe that's why they use white text? Your aqua buttons (Voir) do have black text. |
React is not customizing the colors like angular is. |
If I look at Bootstrap's example buttons at https://getbootstrap.com/docs/5.3/components/buttons/, it seems like their colors are more appropriate. Maybe the Bootswatch theme is causing the issue? |
This issue is stale because it has been open for too long without any activity. |
It still seems weird that React uses white text and Angular uses black. |
Overview of the issue
In previous versions of JHipster, I'm pretty sure the buttons had white text on buttons with colored backgrounds. In v7.7.0, the text is black.
Motivation for or Use Case
I believe the button text was white in previous releases. If you look at my blog post with v7.4.1, it does use a custom theme, but the button text is also white.
Reproduce the error
Create a new project with entities.
JHipster Version(s)
JHipster configuration, a
.yo-rc.json
file generated in the root folder.yo-rc.json file
JDL for the Entity configuration(s)
entityName.json
files generated in the.jhipster
directoryJDL entity definitions
Environment and Tools
openjdk version "17.0.2" 2022-01-18
OpenJDK Runtime Environment GraalVM CE 22.0.0.2 (build 17.0.2+8-jvmci-22.0-b05)
OpenJDK 64-Bit Server VM GraalVM CE 22.0.0.2 (build 17.0.2+8-jvmci-22.0-b05, mixed mode, sharing)
git version 2.32.0 (Apple Git-132)
node: v16.13.2
npm: 8.1.2
Docker version 20.10.12, build e91ed57
Docker Compose version v2.2.3
The text was updated successfully, but these errors were encountered: