Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JHipster does not recognize Node.js 18 as LTS #20349

Closed
1 task done
vdespa opened this issue Nov 17, 2022 · 14 comments
Closed
1 task done

JHipster does not recognize Node.js 18 as LTS #20349

vdespa opened this issue Nov 17, 2022 · 14 comments
Assignees
Labels
area: triage $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ theme: github_actions Pull requests that update Github_actions code $500 https://www.jhipster.tech/bug-bounties/
Milestone

Comments

@vdespa
Copy link

vdespa commented Nov 17, 2022

Overview of the issue

JHipster issues the following warning when used with Node.js 18: "WARNING! Your Node version is not LTS (Long Term Support), use it at your own risk! JHipster does not support non-LTS releases, so if you encounter a bug, please use a LTS version first."

image

Motivation for or Use Case
Reproduce the error

Run jhipster

Related issues
Suggest a Fix
JHipster Version(s)

JHipster v7.9.3

JHipster configuration
Entity configuration(s) entityName.json files generated in the .jhipster directory
Browsers and Operating System

macOS

  • Checking this box is mandatory (this is just to show you read everything)
@mraible
Copy link
Contributor

mraible commented Nov 17, 2022

Yes, we should fix this. I'll add a bug bounty.

@mraible mraible added $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ $500 https://www.jhipster.tech/bug-bounties/ theme: github_actions Pull requests that update Github_actions code labels Nov 17, 2022
@mshima mshima added this to the 7.9.4 milestone Nov 17, 2022
@mshima
Copy link
Member

mshima commented Nov 17, 2022

@DanielFran assigned to you. 😄
WARNING! Your Node version is not LTS (Long Term Support), use it at your own risk! JHipster does not support non-LTS releases, so if you encounter a bug, please use a LTS version first.
The error message seems the node is 18 prior to LTS version.
The warning didn't show at MacOS M1 + node 18.12.1

The logic looks ok:

if (!(process.release || {}).lts) {
this.warning(
'Your Node version is not LTS (Long Term Support), use it at your own risk! JHipster does not support non-LTS releases, so if you encounter a bug, please use a LTS version first.'
);
}

Just need a new release.

@mraible
Copy link
Contributor

mraible commented Nov 17, 2022

Are we sure JHipster v7 works with Node 18? This issue suggests it does not.

@antarus
Copy link
Contributor

antarus commented Nov 18, 2022

with 18, I don't get the same error when I run it.

image

work with 16.

windows 10 with wsl2

@mshima mshima mentioned this issue Nov 18, 2022
6 tasks
@mshima
Copy link
Member

mshima commented Nov 18, 2022

Following #20394:

Generation works and as long as ./npmw is used instead of the system node/npm, the application will work fine.

@vdespa
Copy link
Author

vdespa commented Nov 18, 2022

with 18, I don't get the same error when I run it.

That is issue #19627

@dagboujhatem
Copy link

With the node V18.15.2 I don't get the same error when I run it.
OS: macOS

@ljoboy
Copy link

ljoboy commented May 28, 2023

With node v18.16.0 same error
OS: Linux Mint

@BrayanMnz
Copy link
Contributor

Are you working on this @DanielFran ?

@BrayanMnz
Copy link
Contributor

Seems like just a release was needed and this is not an issue anymore.
maybe this can be closed.

@deepu105
Copy link
Member

deepu105 commented Sep 5, 2023

closing as release v7.9.4 is being done

@deepu105 deepu105 closed this as completed Sep 5, 2023
@vishal423
Copy link
Contributor

Blueprints still doesn't work with nodejs v18 due to incorrect module exports on the JHipster side. Refer jhipster/generator-jhipster-svelte#1841

@deepu105 , can we reopen?

@deepu105 deepu105 reopened this Oct 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

JHipster has completed the sample check
.yo-rc.json:
Entities JDL:
Application: successfully generated
Frontend check: skipped
Backend check: skipped
E2E check: skipped

@mshima
Copy link
Member

mshima commented Jan 13, 2024

Changing the package.json exports for generator-jhipster will almost for sure be a breaking change.
We support node 18 in v8.
Closing.

@mshima mshima closed this as completed Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: triage $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ theme: github_actions Pull requests that update Github_actions code $500 https://www.jhipster.tech/bug-bounties/
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants