Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sonar: Update this function so that its implementation is not identical to the one #25134

Closed
qmonmert opened this issue Feb 8, 2024 · 1 comment · Fixed by #25208
Closed

Sonar: Update this function so that its implementation is not identical to the one #25134

qmonmert opened this issue Feb 8, 2024 · 1 comment · Fixed by #25208
Labels
theme: sonar
Milestone
8.2.1

Comments

@qmonmert
Copy link
Contributor

qmonmert commented Feb 8, 2024 •
edited
Loading

https://sonarcloud.io/project/issues?resolved=false&sinceLeakPeriod=true&types=CODE_SMELL&id=jhipster-sample-application&open=AY1qKP60ZqAZOZp0Vj8n

image

@mshima you added directive SortBySignalDirective below SortByDirective, we kept two directives?
@mshima
Copy link
Member

mshima commented Feb 9, 2024

We should drop the former one.
I haven’t look into it yet.
I am trying to simplify entity code all over the place.

@mshima mshima mentioned this issue Feb 15, 2024
Merged
6 tasks
@deepu105 deepu105 added this to the 8.2.0 milestone Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
theme: sonar
Projects
None yet
Milestone
8.2.1
Development

Successfully merging a pull request may close this issue.

migrate admin ui to new sort directives mshima/generator-jhipster
3 participants
@deepu105 @mshima @qmonmert