Skip to content
This repository has been archived by the owner on Mar 21, 2021. It is now read-only.

Merge on JDL Import #281

Closed
1 task done
brunnels opened this issue Nov 7, 2018 · 1 comment
Closed
1 task done

Merge on JDL Import #281

brunnels opened this issue Nov 7, 2018 · 1 comment

Comments

@brunnels
Copy link

brunnels commented Nov 7, 2018

Overview of the feature request

Change the jhipster_entity_exporter to deep merge the generated json with the current json if it exists. Similar to how the MergeJsonWebpackPlugin does with the i18n files.

Motivation for or Use Case

This would allow blueprint authors to use the entity configurations to store additional settings or parameters that are not supported by the JDL. Anything that is supported by the JDL should continue to be maintained in there.

Additional settings in the entity json works as is now but any changes get overwritten on jdl-import so merging would be much more user friendly.

The primary hurdle would be updating object_utils::areEntitiesEqual to only check for JDL supported fields. Possibly have an AllJdlEntityFields object with all the supported fields and then copy the values from the generated entity and current entity into new AllEntityFields objects before comparing them?

  • Checking this box is mandatory (this is just to show you read everything)
@MathieuAA
Copy link
Member

Sorry for the late answer, I admit I forgot about this issue as I didn't have much time before. I have the JDL exporting to improve right now, but this issue shall be the next priority.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants