Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module to make custom JHLite instance #3482

Closed
2 tasks done
DamnClin opened this issue Sep 9, 2022 · 18 comments · Fixed by #3591
Closed
2 tasks done

Module to make custom JHLite instance #3482

DamnClin opened this issue Sep 9, 2022 · 18 comments · Fixed by #3591
Labels
area: feature request 💡 $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ generator: internal $200 https://www.jhipster.tech/bug-bounties/

Comments

@DamnClin
Copy link
Collaborator

DamnClin commented Sep 9, 2022

Create a module to make custom JHLite instances to allow custom modules.

TODO:

  • Deploy releases on maven central (cc @pascalgrimaud);
  • Make the module.

In fact the module is pretty simple, it needs:

  • The JHLite dependency;
  • An updated main class with @SpringBootApplication(scanBasePackageClasses = { JHLiteApp.class, JHipsterCustomApp.class })
  • Some documentation.
@pascalgrimaud
Copy link
Member

Cc @avdev4j : we should discuss about this

@hdurix
Copy link
Member

hdurix commented Sep 13, 2022

Good idea 👍

It would be easy to customize the common JHipster Lite!

@pascalgrimaud
Copy link
Member

@jdubois : can you help here as you're the admin in the sonatype orga? I wonder if we can already publish this artifact or should we do a new request?

@jdubois
Copy link
Member

jdubois commented Sep 14, 2022

@pascalgrimaud I don't understand, you want a specific project for JHipster Lite on Sonar cloud?

@pascalgrimaud
Copy link
Member

@jdubois : no I want to publish to maven central, managed by sonatype (not sonarcloud)

@jdubois
Copy link
Member

jdubois commented Sep 14, 2022

Oh sorry! Sonar/Sonatype this is confusing... As long as it's in the same groupId (tech.jhipster) I think you can directly push, and it will create a new project in that groupId. I can then check in the UI and give you statistics.

@pascalgrimaud
Copy link
Member

Thanks, I'll try to publish it, so :-)

@pascalgrimaud
Copy link
Member

Good news, it seems to work:

I'm preparing the other PRs to update the current pom.xml

@pascalgrimaud pascalgrimaud added $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ $200 https://www.jhipster.tech/bug-bounties/ labels Sep 14, 2022
@pascalgrimaud
Copy link
Member

I'm adding the bounty on the 2nd part: the module to generate this project.
This part can be done only after the release

@pascalgrimaud
Copy link
Member

I manage to init the repository, but I think it needs to be validated.

@jdubois : can you log and have a look at https://oss.sonatype.org/#stagingRepositories plz ?

image

@pascalgrimaud
Copy link
Member

And if I go to https://oss.sonatype.org/service/local/staging/deploy/maven2/tech/jhipster/lite I have this error:

<nexus-error>
<errors>
<error>
<id>*</id>
<msg>Staging of Repository within profile ID='58b316c0f54bc' is not yet started!</msg>
</error>
</errors>
</nexus-error>

@pascalgrimaud
Copy link
Member

Maybe try to release it:

image

@pascalgrimaud pascalgrimaud pinned this issue Sep 14, 2022
@pascalgrimaud
Copy link
Member

I found the documentation about the workflow here : https://help.sonatype.com/repomanager2/staging-releases/managing-staging-repositories

@DamnClin
Copy link
Collaborator Author

DamnClin commented Sep 19, 2022

The published jar is a spring boot style jar: that mean we can't really use it as a dependency since we won't have access to the JHLite classes.

We can decide to:

  • Publish a "classic" jar;
  • Publish a spring-boot AND "classic" jar using maven-jar-plugin;

Publishing the spring-boot jar don't seems to make a lot of sense since we already have a published docker image and the possibility to download it from github releases.

@pascalgrimaud what do you think? Any other impact I missed?

@avdev4j
Copy link
Contributor

avdev4j commented Sep 19, 2022

hi @DamnClin
Does that mean we can use this to generate empty modules to create our own? A kind of module starter, or something else?

Sorry if my question seems to be weird but I wanted to be sure ;-)

@DamnClin
Copy link
Collaborator Author

Not really. The goal is to be able to deploy an application and add custom JHLite modules without adding them to the open source project.

It is designed to allow custom modules in organizations. Ex: you are entando and want to deploy an instance without the module you don't support and with some specific modules.

@DamnClin DamnClin unpinned this issue Sep 21, 2022
@DamnClin
Copy link
Collaborator Author

@pascalgrimaud
Copy link
Member

@DamnClin : approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: feature request 💡 $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ generator: internal $200 https://www.jhipster.tech/bug-bounties/
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants