Fix #167: prefix non-enumerable globals with var
#168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rensbaardman
force-pushed
the
fix-167-global-var-leakage
branch
from
e45e986
to
7bec7f8
Compare
2 tasks
rensbaardman
changed the title
varvar
|
@jhnns can you please review, merge and release a new patch version? |
|
Thank you 🙏 Published as v6.0.0 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #167,
getImportGlobalsSrc.jsmissed all the non-enumerable globals. There are quite a lot of them (way more than the handful of enumerable globals in Node). This fixes a failing test, that depended on whetherconsolewas an enumerable global or not. It was in Node 9, it wasn't in Node 10.