Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with next version of ggplot2 #130

Closed
thomasp85 opened this issue Oct 10, 2022 · 3 comments · Fixed by #132
Closed

Issues with next version of ggplot2 #130

thomasp85 opened this issue Oct 10, 2022 · 3 comments · Fixed by #132
Assignees
Labels
bug Something isn't working

Comments

@thomasp85
Copy link

Hi

We preparing the next release of ggplot2 and our reverse dependency checks show that your package is failing with the new version. Looking into it we see that the issues are due to our switch to using the linewidth aesthetic for stroke width instead of size. Please see https://www.tidyverse.org/blog/2022/08/ggplot2-3-4-0-size-to-linewidth/ for more info on this.

You can install the release candidate of ggplot2 using devtools::install_github('tidyverse/ggplot2@v3.4.0-rc') to test this out.

We plan to submit ggplot2 by the end of October and hope you can have a fix ready before then

Kind regards
Thomas

@thomasp85 thomasp85 added the bug Something isn't working label Oct 10, 2022
@henriquesposito henriquesposito self-assigned this Oct 11, 2022
@henriquesposito
Copy link
Collaborator

The easiest solution, already implemented, is to change manually to ´linewidth´ and remind users to also update to a newer version of ´{ggplot2}´ (if they have not already done so).

I am not sure just yet about what it would take to implement a more flexible solution that works for both older and newer versions of ´{ggplot2}´... Ideally, this would be a better alternative!

@thomasp85
Copy link
Author

You can have a look at ggforce that has made changes to work with both current and future ggplot2 versions. Whether it applies to this package is hard to say but there should be some inspiration

@henriquesposito
Copy link
Collaborator

Will do, thank you for your help @thomasp85!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants