ignore dotfiles and backup files in the watch list #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhthorsen
reviewed
Oct 2, 2016
| my ($self, $args) = @_; | ||
| my ($self, $changed, $args) = @_; | ||
| do { warn "[prowess] no desired changes\n" if DEBUG; } and return unless $changed; | ||
| return if DEBUG > 1; |
There was a problem hiding this comment.
I don't think $changed should be passed into this method... se my comment later.
| @@ -40,17 +42,20 @@ sub run { | |||
| my $self = shift; | |||
| my $args = $self->parse_argv(@_); | |||
| my $watcher = Filesys::Notify::Simple->new($args->{watch}); | |||
| my $ignore = qr{(?:/\.[^/]+$|\.bak$|\.old$|\.swp$|~$)}; | |||
| my $exit = 0; | ||
|
|
||
| while (1) { | ||
| my $pid = $self->run_prove($args->{prove}); | ||
| my $pid = $self->run_prove($changed, $args->{prove}); |
There was a problem hiding this comment.
Could this be this instead:
my $pid = $changed ? $self->run_prove($args->{prove}) : 0;
| $watcher->wait( | ||
| sub { | ||
| return unless my @changed = grep { !-d $_ } map { $_->{path} } @_; | ||
| warn "[prowess] changed: @changed\n" if DEBUG; | ||
| return unless $changed = my @changed = grep { !-d $_ && $_ !~ $ignore } map { $_->{path} } @_; |
There was a problem hiding this comment.
Do you need both @Changed and $changed?
s1037989
force-pushed
the
ignore_some_files
branch
from
24c46a8
to
7e543b8
Compare
|
Good suggestions! I think this meets all your feedback! What do you think about the DEBUG level 2 ability? Too much? Unnecessary? Shoot, proly so... Rather than testing on a big project with lots of tests, test on app-prowess itself! |
s1037989
force-pushed
the
ignore_some_files
branch
from
7e543b8
to
ed078b3
Compare
s1037989
commented
Oct 2, 2016
| my $exit = 0; | ||
|
|
||
| while (1) { | ||
| my $pid = $self->run_prove($args->{prove}); | ||
| my $pid = @changed ? $self->run_prove($args->{prove}) : 0; |
There was a problem hiding this comment.
This was way more simple. Why do sometimes the most simple and obvious solutions elude me??
s1037989
commented
Oct 2, 2016
| $watcher->wait( | ||
| sub { | ||
| return unless my @changed = grep { !-d $_ } map { $_->{path} } @_; | ||
| return unless @changed = grep { !-d $_ && $_ !~ $ignore } map { $_->{path} } @_; | ||
| warn "[prowess] changed: @changed\n" if DEBUG; |
There was a problem hiding this comment.
There was no real value to showing the number of files changed.
|
LGTM! |
jhthorsen
pushed a commit
that referenced
this pull request
Oct 2, 2016
- Ignore dotfiles and backup files in the watch list #3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.