Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow a custom URL object with userinfo in constructor #41

Merged
merged 1 commit into from Feb 12, 2019
Merged

allow a custom URL object with userinfo in constructor #41

merged 1 commit into from Feb 12, 2019

Conversation

Grinnz
Copy link
Collaborator

@Grinnz Grinnz commented Feb 12, 2019

Currently if you pass a Mojo::URL object into the constructor it will be stringified into a new Mojo::URL object, losing any userinfo data. This allows a Mojo::URL object to be passed through unchanged.

@jhthorsen
Copy link
Owner

Yikes! That’s so stupid :(

Thanks for the fix!

@jhthorsen jhthorsen merged commit ecf9658 into master Feb 12, 2019
jhthorsen pushed a commit that referenced this pull request Apr 4, 2019
Released version 3.20
37c5628 
 - Use Protocol::Redis::Faster instead of Protocol::Redis #38
 - Only decode data from bulk string responses #40
 - Fix allowing custom URL object with userinfo in constructor #41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Grinnz @jhthorsen