Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new stream commands in Redis 5.0.0 #45

Open
jhthorsen opened this issue Apr 24, 2019 · 0 comments
Open

Implement new stream commands in Redis 5.0.0 #45

jhthorsen opened this issue Apr 24, 2019 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@jhthorsen
Copy link
Owner

There's some new stream commands that are not implemented:

$ CHECK_METHOD_COVERAGE=1 TEST_ONLINE=redis://localhost/8 prove -vl t/method-coverage.t
...
not ok 179 - not implemented: xack (xack)
not ok 181 - not implemented: xclaim (xclaim)
not ok 182 - not implemented: xdel (xdel)
not ok 183 - not implemented: xgroup (xgroup)
not ok 184 - not implemented: xinfo (xinfo)
not ok 191 - not implemented: xtrim (xtrim)

These methods should be added to Mojo::Redis::Database. Adding them to @BASIC_COMMANDS could be enough, but I'm not sure. Doing so and running the test again will generate documentation though, so it might be a good place to start.

@jhthorsen jhthorsen added help wanted Extra attention is needed good first issue Good for newcomers labels Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant