Remove the ->multi_p(@promises) syntax #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See jhthorsen#68 for details. The problem is that when calling multi_p(@Promises), the promises are already constructed when entering the multi_p subroutine, and their commands could already be in flight to Redis, so they can be executed outside the transaction, before the multi_p can issue the MULTI command to Redis.
jhthorsen
approved these changes
Nov 13, 2021
jhthorsen
pushed a commit
that referenced
this pull request
Nov 20, 2021
- Add experimental "subscribe" and "psubscribe" events to Mojo::Redis::PubSub - Fix examples for set and expire #62 - Fix handling "psubscribe" response from Redis #63 - Fix sending database requests after connecting to sentinel server #64 - Fix only passing on (p)message messages to listen handlers #67 - Remove experimental write_q() method, and replaced it with write() - Remove the ->multi_p(@Promises) syntax #68 #70 Contributor: Jan "Yenya" Kasprzak
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #68 for details.
The problem is that when calling multi_p(@Promises), the promises
are already constructed when entering the multi_p subroutine, and their
commands could already be in flight to Redis, so they can be executed
outside the transaction, before the multi_p can issue the MULTI command
to Redis.