Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage note #1

Closed
vhscom opened this issue May 18, 2022 · 2 comments
Closed

Usage note #1

vhscom opened this issue May 18, 2022 · 2 comments

Comments

@vhscom
Copy link

vhscom commented May 18, 2022

I'm sure this wasn't easy to create. And I applaud you for doing so. But I think it might be worth noting in the README the same thing can be accomplished along with dropping debuggers with a few lines of Vite config.

SvelteKit users:

kit: {
  adapter: adapter(),
  vite: {
    esbuild: { drop: ['console', 'debugger'] }
  }
}

I opened this issue in hopes to get this documented and prevent Vite plug-in sprawl in SvelteKit. I hope you will consider documenting this for the benefit of your users and those who are still learning to help them keep their apps as simple as possible.

@jhubbardsf
Copy link
Owner

Good point!

@jhubbardsf
Copy link
Owner

Updated the readme and linked to the esbuild drop config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants