Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need test cases for dynamic message's MergeFrom and MergeInto methods #149

Closed
jhump opened this issue Aug 3, 2018 · 1 comment
Closed

Comments

@jhump
Copy link
Owner

jhump commented Aug 3, 2018

Some of this logic is indirectly exercised via some of the tests (and the grpcurl project actually relies on these functions, and some of its tests exercise even more of the code).

But recently found bugs like addressed in #146 show that there are still some ugly corners in here. There are TODOs for test cases for these methods, and actually addressing these TODOs is rising in urgency.

@jhump
Copy link
Owner Author

jhump commented Sep 2, 2020

Now that the new protobuf runtime includes a dynamic message implementation (in google.golang.org/protobuf/types/dynamicpb), I do not intend to add test coverage of my own package.

A future v2 of this repo will not include the desc and dynamic packages as that functionality is now provided in the core runtime.

@jhump jhump closed this as completed Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant