Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MethodOptions.uninterpreted_option difference with protoc if {} #252

Closed
bufdev opened this issue Jul 29, 2019 · 0 comments · Fixed by #253
Closed

MethodOptions.uninterpreted_option difference with protoc if {} #252

bufdev opened this issue Jul 29, 2019 · 0 comments · Fixed by #253

Comments

@bufdev
Copy link
Contributor

bufdev commented Jul 29, 2019

I could have sworn we dealt with this, but I can't find the issue.

Example:

service Foo {
  rpc Bar(Empty) returns (Empty);
  rpc Baz(Empty) returns (Empty) {}
}

Bar will return the same value for MethodOptions.uninterpreted_option in both protoc and goprotoc, but Baz will have an empty non-nil array in goprotoc, and a nil array in protoc.

This is whatever the opposite of important is, but is getting in the way of automated protoc vs goprotoc testing with proto.Equal unfortunately.

I really thought we dealt with {} vs ;, maybe this is a "regression" ie 3.9.0 is doing something different (the above was done with protoc 3.9.0). EDIT: Also done with protoc 3.7.1, happens with 3.7.1 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant