Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax error on gem 5.1.0 #176

Open
michelboaventura opened this issue Feb 27, 2019 · 2 comments
Open

Syntax error on gem 5.1.0 #176

michelboaventura opened this issue Feb 27, 2019 · 2 comments

Comments

@michelboaventura
Copy link

Hi,

The file lib/filterrific/engine_api.rb inside gem version 5.1.0 has a syntax error. The line beginning with TODO should've been commented.

# -*- coding: utf-8 -*-

require 'filterrific/param_set'

require 'filterrific/action_controller_extension'
require 'filterrific/active_record_extension'

module Filterrific
  class EngineApi < ::Rails::Engine

TODO: Since this is API only, I don't think we need an engine!
    # It's an engine so that we can add javascript and image assets
    # to the asset pipeline.

    isolate_namespace Filterrific

    ActiveSupport.on_load :action_controller do
      include Filterrific::ActionControllerExtension
    end

    ActiveSupport.on_load :active_record do
      extend Filterrific::ActiveRecordExtension
    end

  end
end
@Hamdan85
Copy link

Hamdan85 commented Apr 2, 2019

I'm also having this issue

@Hamdan85
Copy link

Hamdan85 commented Apr 2, 2019

in fact, the code in this repository is already OK. Probably @jhund didnt updated rubygems

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants