LeafNode.value is not cloned in LeafNode.clone()

[fluorumlabs]

Affected version: At least 1.11.3, but most likely 1.11.1 and above

Consider the following example:

/* 1 */ TextNode x = new TextNode("zzz");
/* 2 */ x.attributes(); // this calls LeafNode.ensureAttributes() and creates attributes map
/* 3 */ TextNode y = (TextNode) x.clone();
/* 4 */ y.text("xxx"); // now x.text() is also "xxx"

• Here, on step 1 we create a new TextNode with a value of zzz.
• On step 2 ensureAttributes() is called indirectly, which replaces String value with Attributes containing #text = zzz entry.
• On step 3 we clone the node.
• If we inspect properties after step 3 we'll notice that x.attributes() and y.attributes() are returning the same instance
• On step 4 we update content of y, which is "magically" mirrored to x as well.

In 1.10.3 attributes were explicitly cloned in Node.doClone() method, but starting with 1.11.1 attributes were moved to TextNode and then to LeafNode without any clone implementation.

[fluorumlabs]

Temporary workaround is to call this before every Document.clone:

/**
 * Temporary workaround for https://github.com/jhy/jsoup/issues/1176
 *
 * @param document
 */
private static void workaroundForJsoupIssue1176(Document document) {
	document.getAllElements().forEach(element -> {
		for (TextNode textNode : element.textNodes()) {
			TextNode flattenedTextNode = new TextNode(textNode.getWholeText());
			textNode.replaceWith(flattenedTextNode);
		}
	});
}

[jhy]

Thanks! Fixed